Skip to content

Conversation

@theEvilReaper
Copy link
Contributor

@theEvilReaper theEvilReaper commented Nov 3, 2025

Proposed changes

The pull request changes the parameter usage in the DELETE request of the {id}/sources/delete endpoint in the SoundController. With the current implementation there is the problem that it requires the complete SoundFileSourceDTO to get the id from it. This is a bit stupid and requires more data which must be send over the network.

So this pull request changes the required parameter to the id from the model which is must better for the network and reduces complexity.

Types of changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.

  • I have read the CONTRIBUTING.md
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@theEvilReaper theEvilReaper self-assigned this Nov 3, 2025
@theEvilReaper theEvilReaper added the enhancement New feature or request label Nov 4, 2025
@TheMeinerLP
Copy link
Contributor

@theEvilReaper Can you resolve the conflicts ?

@theEvilReaper theEvilReaper force-pushed the rework/soundSourceDelete branch from 72de5e4 to ed92f87 Compare November 5, 2025 09:50
@theEvilReaper
Copy link
Contributor Author

@TheMeinerLP I resolved the conflict

Copy link
Contributor

@TheMeinerLP TheMeinerLP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@theEvilReaper theEvilReaper merged commit 8b53e0e into beta Nov 5, 2025
4 checks passed
@theEvilReaper theEvilReaper deleted the rework/soundSourceDelete branch November 5, 2025 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants